[Android] Bottomsheet: app crashes when there is active button in the bottomsheet and being dismissed #8038

Activity

1. hamidbsd commented on Oct 30, 2019

   

   hamidbsd

   on Oct 30, 2019

   ContributorAuthor

   More actions

   @farfromrefug suggested I report it here.
   nativescript-community/ui-material-components#71
2. tsonevn commented on Oct 31, 2019

   

   tsonevn

   on Oct 31, 2019

   Contributor

   More actions

   Hi @hamidbsd,
   Can you send us a sample project, where the issue, you are facing, can be reproduced?
3. tsonevn

   added

   needs more info

   on Oct 31, 2019
4. farfromrefug commented on Oct 31, 2019

   

   farfromrefug

   on Oct 31, 2019

   Collaborator

   More actions

   @tsonevn i asked @hamidbsd to add it here cause i already see an issue in the code:
   

   NativeScript/nativescript-core/ui/core/view/view.android.ts

   Line 382 in cc97a16

   this.nativeViewProtected.setOnTouchListener(null);

   
   There you don't check for nativeViewProtected. And it might be null un unloaded.
   I think it is an edge case

   Also should i mention that it should be done in disposeNativeView and not onUnloaded
5. hamidbsd commented on Nov 20, 2019

   

   hamidbsd

   on Nov 20, 2019

   ContributorAuthor

   More actions

   Here is a simple project to reproduce the crash.
   I needs {N} 6.2.1 + latest Angular + [email protected]
   https://www.dropbox.com/s/m1weedpegpo0rlv/Bottomsheet%20crashing.zip?dl=0

   👍React with 👍1Reacted by Nikolay Tsonev
6. hamidbsd

   changed the title [-][Android] Modal: app crashes when (touch) is captured in the modal and being dismissed[/-] [+][Android] Bottomsheet: app crashes when there is active button in the bottomsheet and being dismissed[/+] on Nov 21, 2019
7. tsonevn

   added

   os: android

   on Nov 21, 2019
8. hamidbsd commented on Nov 24, 2019

   

   hamidbsd

   on Nov 24, 2019

   Last edited by hamidbsd

   ContributorAuthor

   More actions

   @tsonevn I did what @farfromrefug suggested and it worked!
   I changed this:
   

   NativeScript/nativescript-core/ui/core/view/view.android.ts

   Lines 381 to 385 in cc97a16

   	if (this.touchListenerIsSet) {
   	this.nativeViewProtected.setOnTouchListener(null);
   	this.touchListenerIsSet = false;
   	this.nativeViewProtected.setClickable(this._isClickable);
   	}

   to this:

           if (this.touchListenerIsSet) {
               this.touchListenerIsSet = false;
               if (this.nativeViewProtected) {
                   this.nativeViewProtected.setOnTouchListener(null);
                   this.nativeViewProtected.setClickable(this._isClickable);
               }
           }
   
   

   And it works like a charm!

   👍React with 👍1Reacted by Netshedzo
9. hamidbsd

   closed this as completedon Nov 27, 2019
10. hamidbsd

    reopened this on Nov 27, 2019
11. hamidbsd

    closed this as completedon Dec 17, 2019