Skip to content

extraAttributes should nest #330

Open

Description

@ZevEisenberg
case let .extraAttributes(attributes):
    self.extraAttributes = attributes

Instead of just assigning, we should merge the attributes so that any shared keys in the right-hand side overwrite those keys in the left-hand side.

Question: any way to un-set custom attributes in the left-hand side by passing something in the right-hand side? Or should we just assume that the developer will pass some sentinel value like NSNull()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions