Repository navigation

Implement `strict_mode` keyword parameter in `binascii.a2b_base64()` #4374

Closed

Assignees

opened

on Dec 27, 2022

Since Python 3.11, binascii.a2b_base64() function became to provide strict_mode keyword parameter. ¹

Related links

Python docs: https://docs.python.org/3/library/binascii.html?highlight=binascii#binascii.a2b_base64
RustPython implementation:

RustPython/stdlib/src/binascii.rs

Line 147 in 1d8269f

fn a2b_base64(s: ArgAsciiBuffer, vm: &VirtualMachine) -> PyResult<Vec<u8>> {
CPython implementation: https://github.com/python/cpython/blob/deaf509e8fc6e0363bd6f26d52ad42f976ec42f2/Modules/binascii.c#L388

https://docs.python.org/3/library/binascii.html?highlight=binascii#binascii.a2b_base64 ↩

evanrittenhouse commented on Jan 2, 2023
evanrittenhouse
on Jan 2, 2023
Contributor
I can try to take this on! I'm new to Rust/the project but I'll take a stab at it.
Reacted by Lee Dogeon, DimitrisJim and Snowapril
DimitrisJim
assigned
evanrittenhouse
on Jan 3, 2023
evanrittenhouse commented on Jan 14, 2023
evanrittenhouse
on Jan 14, 2023
Contributor
Not sure why that PR got closed - I'm still working on it, though it may take a while.
youknowone commented on Mar 4, 2023
youknowone
on Mar 4, 2023
Member
closed by #4460
youknowone
closed this as completed on Mar 4, 2023

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

evanrittenhouse

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests