Repository navigation
bpython breaks line with ANSI escape code #670
Description
This can be easily reproduced by typing
print('\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[3
1mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[3
1mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m\033[31mOK\033[0m')
In bpython
In Python
I guess when calculating the length of output, bpython counts all chars, but not all chars are visible, thus leading to this bug.
Activity
laike9m commentedon Mar 19, 2017
While I managed to get over the previous issue:
https://github.com/thomasballinger/curtsies/issues/97
I really can't get things to work without this being fixed. I'd appreciate if you could fix it.
laike9m commentedon Mar 23, 2017
@sebastinas @thomasballinger What do you think? Since no other REPLs has this issue, the inconsistency between them and bpython certainly brings undesired behavior to some libraries, which I think is a serious problem.
sebastinas commentedon Mar 23, 2017
Handling of escape characters happens in curtsies. So while this certainly is an issue that affects bpython, it needs to be fixed in curtsies. I think @thomasballinger wouldn't mind getting bug reports and/or test cases for that.
thomasballinger commentedon Apr 4, 2017
Thanks to @ata2001 the second issue you mentioned https://github.com/thomasballinger/curtsies/issues/97 is fixed. Fixing length issues is possible via the wcwidth-based width of a curtsies FmtStr. https://github.com/thomasballinger/curtsies/issues/8 is the most relevant issue for this, we should consider this bpython issue blocked on that, because the version of curtsies currently used in bpython doesn't have this width. (probably because there's no released version of curtsies with a working
.width)laike9m commentedon May 13, 2017
Thanks guys. Looking forward to a new release. 😄
ata2001 commentedon May 13, 2017
Test cases would not be bad for this, but I'd need some help with doing that.