Skip to content

Dropping Python 2 support #819

Closed
Closed

Description

@sebastinas

As Python 2.7 has now reached its end of life, I think it's time to drop all the special cases to support it. I propose to have 0.20 as last version with Python 2.7 support. @supakeen, @thomasballinger, what do you think?

Activity

  1. added this to the release-0.21 milestone on Jul 11, 2020
  2. self-assigned this
    on Jul 11, 2020
  3. thomasballinger commented on Jul 11, 2020

    @thomasballinger
    Member

    That sounds good to me!

    For clarify for others reading (and to confirm) I assume we would not be yanking the old releases or anything, so installing bpython in Python 2 would continue to work; it just wouldn't get any updates.

  4. supakeen commented on Jul 11, 2020

    @supakeen
    Member

    I'm +1 for dropping support (as I added warnings in 0.19) however I might be wary of dropping it so 'quickly'?

    Do you propose removing all the special cases or to not pay attention to them anymore for 0.21?

    @thomasballinger Yea we won't yank old releases :)

  5. thomasballinger commented on Jul 12, 2020

    @thomasballinger
    Member

    It doesn't feel too quick to me, if there were a show-stopping bug we could do a point release. (thanks for adding those warnings too!)

  6. supakeen commented on Jul 12, 2020

    @supakeen
    Member

    Then I agree on the timeframe; @sebastinas did you want to remove all the if py3 stuff and make it the default or not pay attention to them moving forwards?

  7. sebastinas commented on Jul 13, 2020

    @sebastinas
    ContributorAuthor

    I actually want to remove all the if py3 code in 0.21. Leaving them in the code base would give the false impression that we still care about Python 2 after we dropped support for it.

    Considering how often we prepare releases, 0.21 would only happen sometime sometime in 2021. This will give people some time to move on.

  8. supakeen commented on Jul 13, 2020

    @supakeen
    Member

    Yea that makes sense; probably 0.20 somewhere this year if I get to my assigned bugs then 0.21 somewhere first half of next year. I'd love to remove as much as possible in that release (see also the frontends ticket in #820 ).

  9. sebastinas commented on Oct 14, 2020

    @sebastinas
    ContributorAuthor

    Fixed in 07f4fe3 and plenty of commits before that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions