Skip to content

Deprecation warnings due to invalid escape sequences in python 3.8 #853

Closed

Description

@tirkarthi

Deprecation warnings are raised due to invalid escape sequences. This can be fixed by using raw strings or escaping the literals. pyupgrade also helps in automatic conversion : https://github.com/asottile/pyupgrade/

I will raise a PR for this

find . -iname '*.py' | xargs -P4 -I{} python3 -Wall -m py_compile {} 
./bpython/line.py:193: DeprecationWarning: invalid escape sequence \s
  current_method_definition_name_re = LazyReCompile("def\s+([a-zA-Z_][\w]*)")
./bpython/cli.py:943: DeprecationWarning: invalid escape sequence \T
  elif key in ("KEY_NPAGE", "\T"):  # page_down or \T
./bpython/cli.py:947: DeprecationWarning: invalid escape sequence \S
  elif key in ("KEY_PPAGE", "\S"):  # page_up or \S

Activity

  1. added this to the release-0.20 milestone on Oct 11, 2020
  2. thomasballinger commented on Oct 11, 2020

    @thomasballinger
    Member

    I tried to fix this sort of thing in Curtsies and had trouble: bpython/curtsies#128, I'll look at that again now.

  3. thomasballinger commented on Oct 11, 2020

    @thomasballinger
    Member

    Oh I see, that's easy

  4. thomasballinger commented on Oct 11, 2020

    @thomasballinger
    Member

    Two of these come from 0259cf8 and I'm not sure what the original intent was of checking for a curses key code like "\S" or "\T". I'm guessing they should be ^S and ^T, but ^S is usually already used for save. I'm going to remove these.

  5. sebastinas commented on Oct 12, 2020

    @sebastinas
    Contributor

    Fixed in c9a8aa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions