Skip to content

Question: Why there is using a specific model with an abstract repository but not some abstract or base model? #57

Open
Open
Question: Why there is using a specific model with an abstract repository but not some abstract or base model?#57

Description

@svnikolaev
svnikolaev
opened on Jan 18, 2023

Hello,
Can you tell me please why the specific model model.Product used here with the abstract repository AbstractRepository but not some abstract or base model?

code/src/allocation/adapters/repository.py:

code/src/allocation/adapters/repository.py

Line 15 in 69a88f8

def get(self, sku) -> model.Product:

code/src/allocation/adapters/repository.py

Line 28 in 69a88f8

def _add(self, product: model.Product):

code/src/allocation/adapters/repository.py

Line 32 in 69a88f8

def _get(self, sku) -> model.Product:

code/src/allocation/adapters/repository.py

Line 36 in 69a88f8

def _get_by_batchref(self, batchref) -> model.Product:

Activity

  1. hjwp commented on Sep 11, 2023

    @hjwp
    hjwp
    on Sep 11, 2023
    Contributor

    probably you could rename AbstractRepository to AbstractProductRepository. repositories are mean to be specific for one aggregate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions