CreateContainerCmd#withPortBindings and other deprecated methods #1281
Description
I am using 3.1.5 version. and I want to do port binding like :
docker run -d -p 5555:5000 training/webapp python app.py
And i find CreateContainerCmd#withPortBindings is deprecated, Which API can replace this?
I have the same doubt about withPrivileged, which is also deprecated.
Reacted by arnonuem and Semyon Danilov
Activity
EHJ-52n commentedon Mar 19, 2020
From my point of view, the reason for deprecation and which alternative to use should be documented, too.
For example, there are many methods in com.github.dockerjava.api.command.CreateContainerCmd deprecated but no documentation at all.
Is there any source of documentation that can be used for providing this javadoc?
KostyaSha commentedon Mar 19, 2020
everything that "proxy" hostconfig methods are deprecated, use hostconfig directly
EHJ-52n commentedon Mar 19, 2020
Thanks for clarifying this. Is this documented somewhere in the class and I missed it?
[-]CreateContainerCmd#withPortBindings、withPrivileged Deprecated？[/-][+]CreateContainerCmd#withPortBindings and other deprecated methods[/+]bsideup commentedon May 18, 2020
If you see a method deprecated on
CreateContainerCmd, you should be setting it onHostConfig(set/accessed viawithHostConfig()/getHostConfig()).The deprecated methods were just shortcuts and did not match Docker's API.
If someone is up to contributing, a
@deprecated see {#withHostConfig()}comment sounds like a low hanging fruit 👍