Skip to content

Microsoft IE/Edge doesn't seem to be pulling down client configuration settings. #23

Closed

Description

@niemyjski

I noticed this during testing that it doesn't seem to be parsing the header properly.

Activity

  1. changed the title [-]Microsoft Edge doesn't seem to be pulling down client configuration settings.[/-] [+]Microsoft IE/Edge doesn't seem to be pulling down client configuration settings.[/+] on Oct 22, 2015
  2. srijken commented on Oct 22, 2015

    @srijken
    Contributor

    Also seen in IE11, didn't check older browsers.

    The reason here is that XHR.getAllResponseHeaders() returns a string that doesn't confirm to the specification. The string returned in the error instance:

    \nX-Exceptionless-ConfigVersion: 10\r\nX-RateLimit-Limit: 3500\r\nX-RateLimit-Remaining: 3483\r\n\r\n
    

    The problem that causes the issue in Exceptionless.Javascript is the fact that the result of getAllResponseHeaders() starts of with '\n. That in turn causes the header to be stored like this:

    headers['\nX-Exceptionless-ConfigVersion'] = 10;
    

    Because the value is read with the extra \n, the current configVersion can't be read, and that causes the config API endpoint to never be called.

    Fix is to trim the keys when we assign values to the object property.

    Although the leading \n causes the problem, the trailing \r\n\r\n shouldn't be there either according to the specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions