increasing test coverage #229

Activity

1. clewis7 commented on Jun 21, 2023

   

   clewis7

   on Jun 21, 2023

   Last edited by clewis7

   Member

   More actions

       # we skip the rest of the test if you are not using lavapipe
       # images come out subtly differently when using different wgpu adapters
       # so for now we only compare screenshots generated with the same adapter (lavapipe)
       # a benefit of using pytest.skip is that you are still running
       # the first part of the test everywhere else; ensuring that examples
       # can at least import, run and render something
       if not is_lavapipe:
           pytest.skip("screenshot comparisons are only done when using lavapipe")
   

   In regard to screenshot diffs being generated, pygfx just skips if not lavapipe

   @kushalkolar we could add to ours as well, not sure if it is a good long term solution
2. clewis7 commented on Jun 26, 2023

   

   clewis7

   on Jun 26, 2023

   Member

   More actions

   @kushalkolar should we add in the above about skipping screenshot comparison of a test if lavapipe is not being used locally to avoid rendering diffs?
3. kushalkolar commented on Jun 26, 2023

   

   kushalkolar

   on Jun 26, 2023 via email

   MemberAuthor

   More actions

   No we just need to run tests only on lavapipe, if they're skipped it's not useful.

   …

   On Mon, Jun 26, 2023, 08:25 Caitlin Lewis ***@***.***> wrote: @kushalkolar <https://github.com/kushalkolar> should we add in the above about skipping screenshot comparison of a test if lavapipe is not being used locally to avoid rendering diffs? — Reply to this email directly, view it on GitHub <#229 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHXXRDAF3422JF6WWVOHFTXNF5U7ANCNFSM6AAAAAAZHA6JZQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>
4. kushalkolar

   assigned

   clewis7

   on Jun 28, 2023
5. kushalkolar

   changed the title [-]more test stuff[/-] [+]increasing test coverage[/+] on Nov 28, 2023
6. kushalkolar

   added

   good first issueGood for newcomersGood for newcomers

   on Nov 28, 2023
7. kushalkolar commented on Jun 4, 2024

   

   kushalkolar

   on Jun 4, 2024

   MemberAuthor

   More actions

   all this exists now except emulating mouse events, but we have another issue for that.
8. kushalkolar

   closed this as completedon Jun 4, 2024