You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Access yarn as an alternative to npm if npm command fail in preinstall script #1593
I got an error after I use npm test to test my code, the error log show that Expected an identifier and instead saw 'try'. It seems the repo didn't have a jshint.rc to set es5: true, does I need to create a jshint file or is there any other result?
Activity
LuckyPigeon commentedon Jan 14, 2019
I can help, but what exactly would you like me to do?
rmannibucau commentedon Jan 14, 2019
I guess a try(npm).catch(useYarn) logic-like can work.
LuckyPigeon commentedon Jan 16, 2019
So, I need to write a preinstall script for "build from source" user, right?
rmannibucau commentedon Jan 16, 2019
It is already there, just need a fallback on yarn in https://github.com/nodegit/nodegit/blob/master/lifecycleScripts/preinstall.js#L10
LuckyPigeon commentedon Jan 18, 2019
I got an error after I use npm test to test my code, the error log show that
Expected an identifier and instead saw 'try'. It seems the repo didn't have a jshint.rc to setes5: true, does I need to create a jshint file or is there any other result?LuckyPigeon commentedon Jan 30, 2019
@implausible My PR shows up with apt resource error(gpg key timeout), how can I fixed this error?
implausible commentedon Jan 31, 2019
I've restarted that test suite; however, you still have linter errors. Make sure you are using LF terminators and adding EOL LF.