Skip to content

Repository.getReferenceNames returns arrayReference, not arrayString #1707

Closed

Description

@rickharris

System information

  • node version: v12.4.0
  • npm or yarn version: 6.4.1
  • OS/version/architecture: macOS Mojave
  • Applicable nodegit version: v0.25.0-alpha.16

additional info: testing in electron 6 beta

node -v
yarn -v
node -e "console.log(process.platform)"
node -e "console.log(require('os').release())"
node -e "console.log(console.log(process.arch))"

v12.4.0
1.16.0
darwin
18.6.0
x64

Repository#getReferenceNames is documented as returning an array of strings, however in v0.25.0-alpha.16, I am seeing it return an array of Reference objects.

To reproduce the issue:

var repo = await nodegit.Repository.open(pathToRepo)
var refNames = await repo.getReferenceNames(nodegit.Reference.TYPE.LISTALL)
console.log(refNames[0]) //=> Reference {}
console.log(refNames[0].name()) //=> string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions