You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
http_build_query() default null argument for $arg_separator is implicitly coerced to string #12745
changed the title [-]wrong error, http_build_query(): Passing null to parameter #3 ($arg_separator) of type ?string is deprecated[/-][+]http_build_query() default null argument for $arg_separator is implicitly coerced to string[/+]on Nov 22, 2023
Activity
damianwadley commentedon Nov 21, 2023
I'm thinking 76eaff0 should have used
Z_PARAM_STR_OR_NULL. @Girgias ?Girgias commentedon Nov 22, 2023
That is indeed the case, my mistake.
Girgias commentedon Nov 22, 2023
Note the implicit null coercion result in the wrong output
string(18) "hello=worldfoo=bar"instead ofstring(19) "hello=world&foo=bar"[-]wrong error, http_build_query(): Passing null to parameter #3 ($arg_separator) of type ?string is deprecated[/-][+]http_build_query() default null argument for $arg_separator is implicitly coerced to string[/+]Girgias commentedon Nov 22, 2023
Fixed in 37f67a9 (and follow-up af155cf)