Repository navigation
Fix is_zend_ptr() for huge blocks - #14626
Merged
Merged
Conversation
zend_mm_heap.huge_list is NULL-terminated
arnaud-lb
marked this pull request as ready for review
June 24, 2024 16:19
Member
|
I think you may disable the failed FFI test for Windows. |
arnaud-lb
added a commit
that referenced
this pull request
Jun 25, 2024
arnaud-lb
added a commit
that referenced
this pull request
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_zend_ptr()expectszend_mm_heap.huge_listto be circular, but it's in fact NULL-terminated. It may crash when at least one huge block exists and the ptr does not belong to any block.I've checked, and this mistake was not repeated in other places in zend_alloc.