Repository navigation
Hooks on constructor promoted properties without visibility are ignored #15438
Description
Description
The following code:
class C {
public function __construct(
$prop { set => $value * 2; },
) {}
}
$c = new C(42);
var_dump($c);Resulted in this output:
object(C)#1 (0) {
}
But I expected this output instead:
object(C)#1 (1) {
["prop"]=>
int(84)
}
Or compile error
PHP Version
master
Operating System
No response
Activity
SerafimArts commentedon Aug 16, 2024
Shouldn't promoted properties have visibility? In this case it's not a promoted property, but a normal constructor argument to which properties (hooks) cannot be applied. IMHO
iluuu1994 commentedon Aug 16, 2024
Not necessarily.
readonlyis a valid cpp modifier.SerafimArts commentedon Aug 16, 2024
Got it, then the presence of properties (hooks) as well as access modifiers makes the arguments a promoted property. Didn't think about that, thanks
Fix param with hooks but no visibility not treated as cpp (phpGH-15442)