Repository navigation
improve proc_open error reporting on Windows #15685
Description
Description
i was launching processes recently and got a Warning: "CreateProcess failed with error code 8" that is generated here:
php-src/ext/standard/proc_open.c
Line 1320 in acd31df
if (newprocok == FALSE) {
//DWORD dw = GetLastError();
close_all_descriptors(descriptors, ndesc);
//php_error_docref(NULL, E_WARNING, "CreateProcess failed, error code: %u", dw);
php_win32_docref1_from_error(
GetLastError(), ZSTR_VAL(command_str)
);
goto exit_fail;
}ive replaced php_error_docref function with windows specific function which said that was a lack of memory, instead of code 8. so kind of tested it.
Activity
cmb69 commentedon Sep 1, 2024
Oh, indeed, we should use
php_win32_error_to_msg()what's similar to POSIX'strerror().cmb69 commentedon Sep 3, 2024
#15687 has been merged, so this can be closed (would have been automatically, if I hadn't screwed up).