Repository navigation
Unexpected results with output buffering in JIT #16408
Description
Description
The following code:
<?php
$statuses = array();
function oh($str) {
global $statuses;
$statuses[] = "$str";
return $str;
}
ob_start("oh", 3);
ob_flush();
echo "no";
ob_clean();
echo "yes!\n";
echo "no";
ob_end_clean();
print_r($statuses);
?>Resulted in this output:
yes!
noArray
(
[0] =>
[1] => no
[2] => yes!
no
[3] =>
)
But I expected this output instead:
yes!
Array
(
[0] =>
[1] => no
[2] => yes!
[3] => no
)
To reproduce: enable JIT
PHP Version
nightly
Operating System
ubuntu 22.04
Activity
YuanchengJiang commentedon Oct 13, 2024
Another case:
Expected: 3 Actual: 1
iluuu1994 commentedon Oct 13, 2024
The first case is caused not by the JIT but by the optimizer:
Notably, the two
ECHOopcodes get merged. Tbh, I don't think you should be relying on precisely when output buffering is flushed automatically. That seems extremely volatile. If you do need the output to be flushed at a certain point in time, then there's alwaysob_flush(). So, IMO this is a #wontfix.The second report may be worth fixing.
Opcache is converting some constant operands to strings using
convert_to_string()at optimization time. However, this 1. prevents the warnings from being printed at runtime 2. prints the warning at optimization time, at which point the handler isn't installed yet. We should probably only convert operands that don't emit errors.Fix array to string conversion warning emitted in optimizer
Fix array to string conversion warning emitted in optimizer