"P" format for ::createFromFormat swallows string literals #17159

Activity

1. PrinsFrank

   added

   Bug

   Status: Needs Triage

   on Dec 14, 2024
2. ndossche commented on Dec 14, 2024

   

   ndossche

   on Dec 14, 2024

   Last edited by ndossche

   Member

   More actions

   Yeah timelib_parse_zone eats as many ( or horizontal whitespace as possible at the start, and then eats as many ) as possible at the end. One would assume that the number of ( and ) eaten must match, which would fix this issue. However, that may also break BC.

   php-src/ext/date/lib/parse_date.re

   Lines 994 to 996 in 7bfd198

   	while (**ptr == ')') {
   	++*ptr;
   	}

   So a patch like this works, and your sample code now returns the right object instead of false:

   diff --git a/ext/date/lib/parse_date.c b/ext/date/lib/parse_date.c
   index ea1602ef13b..fa71e8210ad 100644
   --- a/ext/date/lib/parse_date.c
   +++ b/ext/date/lib/parse_date.c
   @@ -944,7 +944,9 @@ timelib_long timelib_parse_zone(const char **ptr, int *dst, timelib_time *t, int
    
    	*tz_not_found = 0;
    
   +	size_t paren_count = 0;
    	while (**ptr == ' ' || **ptr == '\t' || **ptr == '(') {
   +		paren_count += **ptr == '(';
    		++*ptr;
    	}
    	if ((*ptr)[0] == 'G' && (*ptr)[1] == 'M' && (*ptr)[2] == 'T' && ((*ptr)[3] == '+' || (*ptr)[3] == '-')) {
   @@ -993,8 +995,9 @@ timelib_long timelib_parse_zone(const char **ptr, int *dst, timelib_time *t, int
    		*tz_not_found = (found == 0);
    		retval = offset;
    	}
   -	while (**ptr == ')') {
   +	while (**ptr == ')' && paren_count > 0) {
    		++*ptr;
   +		paren_count--;
    	}
    	return retval;
    }
   

   cc @derickr for opinions on the matter

   👍React with 👍1Reacted by Christoph M. Becker
3. ndossche

   added

   Extension: date

   Status: Verified

   and removed

   Status: Needs Triage

   on Dec 14, 2024
4. Girgias

   added the

   Bug

   issue type on Feb 5, 2025
5. ndossche commented on Sep 15, 2025

   

   ndossche

   on Sep 15, 2025

   Member

   More actions

   Fix merged for the next releases.
6. ndossche

   closed this as completedon Sep 15, 2025