Random extension random.c:95:20: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int' #9083

Activity

1. Girgias

   added

   Bug

   Status: Needs Triage

   Extension: random

   on Jul 21, 2022
2. Girgias

   assigned

   zeriyoshi

   on Jul 21, 2022
3. cmb69 commented on Jul 21, 2022

   

   cmb69

   on Jul 21, 2022

   Member

   More actions

   ext/spl/php_spl.c includes ext/random/php_random.h:

   php-src/ext/spl/php_spl.c

   Line 39 in 067a302

   #include "ext/random/php_random.h"

   However, that is apparently not needed for that compilation unit.
4. guilliamxavier commented on Jul 21, 2022

   

   guilliamxavier

   on Jul 21, 2022

   Contributor

   More actions

   @cmb69 indeed, this line (previously

   php-src/ext/spl/php_spl.c

   Line 39 in 8fec415

   #include "ext/standard/php_mt_rand.h"

   ) could have been removed in fd8770e (maybe should be now)

   But besides that, there's indeed an UB to "fix": #9056 (comment)

   👍React with 👍2Reacted by Christoph M. Becker and Go Kudo
5. Girgias commented on Jul 21, 2022

   

   Girgias

   on Jul 21, 2022

   MemberAuthor

   More actions

   ext/spl/php_spl.c includes ext/random/php_random.h:

   php-src/ext/spl/php_spl.c

   Line 39 in 067a302

   #include "ext/random/php_random.h"

   However, that is apparently not needed for that compilation unit.

   Removing it doesn't seem to fix the issue in SPL anyway
6. guilliamxavier commented on Jul 21, 2022

   

   guilliamxavier

   on Jul 21, 2022

   Contributor

   More actions

   Sorry for the noise:

   php-src/ext/dom/php_dom.c

   Line 25 in f60f6be

   #include "ext/random/php_random.h"

   (previously

   php-src/ext/dom/php_dom.c

   Line 25 in 8fec415

   #include "ext/standard/php_rand.h"

   ) seems unneeded too (but there I don't even see why it was added in the first place)

   Anyway, removing it won't fix the issue either 😅

   👍React with 👍1Reacted by Christoph M. Becker
7. cmb69 commented on Jul 21, 2022

   

   cmb69

   on Jul 21, 2022

   Member

   More actions

   Removing it doesn't seem to fix the issue in SPL anyway

   Nope, but #9056 (comment) should.
8. zeriyoshi

   added

   Status: Verified

   and removed

   Status: Needs Triage

   on Jul 21, 2022
9. TimWolla

   added a commit that references this issue on Jul 21, 2022

   Fix shift in rand_rangeXX()

   ...

   66a557e
10. Girgias

    closed this as completedin #9088on Jul 22, 2022
11. Girgias

    added a commit that references this issue on Jul 22, 2022

    Fix shift in rand_rangeXX() (#9088)

    ...

    ab5491f
12. TimWolla

    added a commit that references this issue on Jul 22, 2022

    [ci skip] Update NEWS for byte expansion in rand_rangeXX()

    ...

    eff9aed