Skip to content

GC root buffer keeps growing when destructors are present #9266

Closed

Description

@olsavmic

Description

When should_rerun_gc in zend_gc_collect_cycles is set to true and the rerun_gc block is run for a second time, the count variable is reset, causing the gc_adjust_threshold potentially increase the size of root buffer indefinitely.

This is particularly dangerous in combination with the fact that GC does not look at the memory usage, keeping very old objects in memory.

This behaviour is causing huge leaks that were fixable by calling gc_collect_cycles manually (see the stable line after calling gc_collect_cycles)

Screenshot 2022-08-03 at 09 04 41

Related to #9239

See the linked MR, I'll try to provide test case asap.

PHP Version

PHP 8.1.9

Operating System

Debian 10

Activity

  1. added a commit that references this issue on Aug 9, 2022
    31a9933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions