Repository navigation
compatibility with ICU 72.1 #9799
Description
Description
The following tests are failed for 8.0/8.1/8.2:
FAILED TEST SUMMARY
---------------------------------------------------------------------
IntlDateFormatter, calendars and time zone [ext/intl/tests/dateformat_calendars_variant3.phpt]
IntlDateFormatter::formatObject(): IntlCalendar tests [ext/intl/tests/dateformat_formatObject_calendar_variant5.phpt]
IntlDateFormatter::formatObject(): DateTime tests [ext/intl/tests/dateformat_formatObject_datetime_variant5.phpt]
datefmt_format_code() and datefmt_parse_code() [ext/intl/tests/dateformat_format_parse_version2.phpt]
datefmt_set_timezone_id_code() icu >= 4.8 [ext/intl/tests/dateformat_set_timezone_id3.phpt]
MessageFormatter::format(): DateTime accepted to format dates and times [ext/intl/tests/msgfmt_format_datetime.phpt]
MessageFormatter::format(): simple types handling with numeric strings [ext/intl/tests/msgfmt_format_simple_types_numeric_strings.phpt]
ResourceBundle constructor bundle accepts NULL for first two arguments [ext/intl/tests/resourcebundle_null_mandatory_args_variant2.phpt]
Alpinelinux started upgrade to new ICU and faced with this failures, see https://gitlab.alpinelinux.org/alpine/aports/-/issues/14283
PHP Version
PHP 8.1.11
Operating System
Alpinelinux
Activity
andypost commentedon Oct 21, 2022
Looks there's not a lot of changes https://icu.unicode.org/download/72
andypost commentedon Oct 21, 2022
symbol after time is changed
EDIT instead of 0x20 before AM now I see 0xE2 0x80 0xAF
cmb69 commentedon Oct 21, 2022
Such changes are not unexpected/unprecedented; in this case the regular space is replaced by NARROW NO-BREAK SPACE. We need to split the affected test cases. I'm already working on a PR.
cmb69 commentedon Oct 21, 2022
@andypost, can you check whether PR #9800 solves the issue for you, or does that need to be merged first?
andypost commentedon Oct 21, 2022
Thank you! Queued the patch to our CI and will report results for 8.2 in ~1h
andypost commentedon Oct 21, 2022
Applies to 7.4 and 8.0 as well except
ext/intl/tests/dateformat_create_default.phptext/intl/tests/datepatterngenerator_get_best_pattern.phpt