Repository navigation
[imaplib] MOVE is a legal command #77517
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-07-23.14:08:22.061>
created_at = <Date 2018-04-22.22:29:42.060>
labels = ['build', '3.8', '3.7', 'extension-modules', 'type-feature', 'library']
title = '[imaplib] MOVE is a legal command'
updated_at = <Date 2018-07-23.14:08:45.001>
user = 'https://github.com/mcepl'bugs.python.org fields:
activity = <Date 2018-07-23.14:08:45.001>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-23.14:08:22.061>
closer = 'vstinner'
components = ['Extension Modules', 'Library (Lib)', 'Cross-Build']
creation = <Date 2018-04-22.22:29:42.060>
creator = 'mcepl'
dependencies = []
files = []
hgrepos = []
issue_num = 33336
keywords = ['patch']
message_count = 14.0
messages = ['315632', '318657', '318658', '321950', '321953', '322078', '322199', '322200', '322201', '322217', '322220', '322222', '322223', '322224']
nosy_count = 5.0
nosy_names = ['vstinner', 'mcepl', 'Alex.Willmer', 'miss-islington', 'Anthony Singleton']
pr_nums = ['6569', '8370', '8373', '8386', '8409', '8410', '8411']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33336'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']
Activity
mcepl commentedon Apr 22, 2018
When running
I get an error "Unknown IMAP4 UID command: MOVE". The problem is that imaplib contains a list Commands of the permitted IMAP commands, and MOVE is not included, even though it is perfectly legal (and quite widely supported) command according to RFC-6851.
vstinner commentedon Jun 4, 2018
https://tools.ietf.org/html/rfc6851
Internet Message Access Protocol (IMAP) - MOVE Extension
January 2013
vstinner commentedon Jun 4, 2018
Should we also add the MOVE command to Python 2.7, 3.6 and 3.7? The change looks safe and trivial.
vstinner commentedon Jul 19, 2018
IMHO it's ok to backport this change. The stdlib must follow evolutions of the IMAP protocol. It's a self contained and safe change, it's not a new Python method.
vstinner commentedon Jul 19, 2018
See also bpo-33327: Add a method to move messages to IMAPlib.
AnthonySingleton commentedon Jul 21, 2018
vstinner commentedon Jul 23, 2018
New changeset caa331d by Victor Stinner (Matěj Cepl) in branch 'master':
bpo-33336, imaplib: Legalize MOVE command (GH-6569)
caa331d
vstinner commentedon Jul 23, 2018
Matěj Cepl: There is a bot to backport changes to other branches. I closed your backport PRs. I prefer to polish the change for the master branch, and only backport later. For example, I modified the commit message of your PR. The bot also uses "git cherry-pick -x" to mention the sha1 of the backported commit which helps to track the origin of backports.
vstinner commentedon Jul 23, 2018
I don't think that "git cherry-pick -x" can be used before a PR is merged, since the merge changes the SHA1 (using our current workflow).
miss-islington commentedon Jul 23, 2018
New changeset 1127849 by Miss Islington (bot) in branch '3.6':
bpo-33336, imaplib: Legalize MOVE command (GH-6569)
1127849
vstinner commentedon Jul 23, 2018
New changeset 96bba04 by Victor Stinner (Miss Islington (bot)) in branch '3.7':
bpo-33336, imaplib: Legalize MOVE command (GH-6569) (GH-8409)
96bba04
miss-islington commentedon Jul 23, 2018
New changeset 7868426 by Miss Islington (bot) in branch '2.7':
bpo-33336, imaplib: Legalize MOVE command (GH-6569)
7868426
vstinner commentedon Jul 23, 2018
Matěj Cepl: Thanks for your change. I applied it to 2.7, 3.6, 3.7 and master branches.
vstinner commentedon Jul 23, 2018