Repository navigation
Remove collections ABCs? #81134
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-10-07.13:21:47.846>
created_at = <Date 2019-05-18.00:52:44.426>
labels = ['3.8', 'library', '3.9']
title = 'Remove collections ABCs?'
updated_at = <Date 2019-10-15.07:30:24.791>
user = 'https://github.com/pganssle'bugs.python.org fields:
activity = <Date 2019-10-15.07:30:24.791>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-07.13:21:47.846>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2019-05-18.00:52:44.426>
creator = 'p-ganssle'
dependencies = []
files = []
hgrepos = []
issue_num = 36953
keywords = ['patch']
message_count = 9.0
messages = ['342779', '342785', '342806', '344005', '354093', '354094', '354137', '354259', '354693']
nosy_count = 10.0
nosy_names = ['rhettinger', 'ned.deily', 'stutzbach', 'serhiy.storchaka', 'mbussonn', 'yan12125', 'p-ganssle', 'eamanu', 'miss-islington', 'xtreak']
pr_nums = ['13409', '16675']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36953'
versions = ['Python 3.8', 'Python 3.9']
Activity
pganssle commentedon May 18, 2019
In PR 5640 (#5460), a warning was added that importing ABCs from collections directly is deprecated and will be removed in Python 3.8, but they have not yet been removed and the warning is still active.
If they are going to be removed, presumably it needs to be done before the feature freeze at the end of May, otherwise, in the meantime, I think the warning needs to be updated to say that it will be removed in Python 3.9.
tirkarthi commentedon May 18, 2019
Relevant PR and discussion : #10596 . pip is incompatible due to the vendored copy of html5lib that needs a new release .
Carreau commentedon May 18, 2019
Should it still raise an informative error message with ImportError:
or just the "cannot import name 'XXXX'" without the "please import it from 'collections.abc'." ?
miss-islington commentedon May 30, 2019
New changeset eea47e0 by Miss Islington (bot) (Matthias Bussonnier) in branch 'master':
bpo-36953: Delay removal of ABCs from collections. (GH-13409)
eea47e0
tirkarthi commentedon Oct 7, 2019
The removal was done in https://bugs.python.org/issue25988 . Given that the version in warning message was updated I guess this can be closed.
yan12125 commentedon Oct 7, 2019
Lib/collections/init.py on branch 3.7 still states:
I think it should also be updated (hopefully before 3.7.5?) as the actual removal turns out to be in 3.9.
eamanu commentedon Oct 7, 2019
Now was remove from 3.7
ef092fe
This issue should be closed, isn't?
miss-islington commentedon Oct 9, 2019
New changeset 056fa7f by Miss Islington (bot) in branch '3.7':
bpo-36953: Delay removal of ABCs from collections. (GH-13409)
056fa7f
ned-deily commentedon Oct 15, 2019
New changeset 42b16b2 by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-36953: Delay removal of ABCs from collections. (GH-13409)
42b16b2