Error code registry. #119

Activity

1. Lukasa

   added

   Easy

   on Apr 11, 2015
2. jdecuyper commented on Apr 30, 2015

   

   jdecuyper

   on Apr 30, 2015

   Contributor

   More actions

   @Lukasa: we could have all the 14 error codes and descriptions loaded in some static array (see spec) and then just use the error code to index into it.

   The file could be called error_code.py and be kept under hyper.http20, any comments?
3. Lukasa commented on May 1, 2015

   

   Lukasa

   on May 1, 2015

   MemberAuthor

   More actions

   Sounds good to me!
4. jdecuyper commented on May 4, 2015

   

   jdecuyper

   on May 4, 2015

   Contributor

   More actions

   @Lukasa hola amigo!

   I'm wondering if this is the way I should throw the GoAway error:

   if frame.error_code != 0:
      err_name = H2_ERROR_CODE_REGISTRY[frame.error_code]['Name']
      err_no = hex(frame.error_code)
      err_description = frame.additional_data or
      H2_ERROR_CODE_REGISTRY[frame.error_code]['Description']
   
      raise ConnectionError(
             "Encountered error %s %s: %s" %
             (err_name, err_no, err_description)
      )
   

   Where H2_ERROR_CODE_REGISTRY is the new array containing all the error codes I have just added.

   Should we make the error information available via the frame itself or have another exception for this?

   I will try to add a new test that consumes a GoAway frame.
5. Lukasa commented on May 5, 2015

   

   Lukasa

   on May 5, 2015

   MemberAuthor

   More actions

   Thanks works well. I don't think the frame itself should know about error code meanings. What you should do, however, is tolerate error codes outside the registry without exploding. =)
6. Lukasa

   closed this as completedon May 8, 2015