Skip to content

Service info is unaware of question history #1337

Closed

Description

@bdraco

If we have multiple consumers of service info asking the same question over and over they all get asked even though we only need to ask once

This is pretty rare except for cases like Home Assistant and pyatv where there are many Apple TVs and we ask for device info over and over

Activity

  1. bdraco commented on Dec 16, 2023

    @bdraco
    MemberAuthor

    To make this work we need to raise the default timeout to 3500ms

    We also need to add the questions to the history.

    We also need to check the history

    Finally we need to make the delay fixed to 1000ms between queries since otherwise they won't get sent because they will hit the 999ms limit

  2. added a commit that references this issue on Dec 16, 2023
    aba80d4
  3. added a commit that references this issue on Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions