Repository navigation
Domain reload crashes when .NET object points to PythonException #1371
Description
Please see this comment: #1361 (comment)
We disabled test_method_parameters_change. Domain reload needs to be fixed so that holding a reference to PythonException is permitted.
I also suspect holding a reference to PyObject in this situation would break refcount based on the source code (serialization does not IncRef => original and deserialized object will both call DecRef).
Activity
lostmsu commentedon Jan 28, 2021
@benoithudson @BadSingleton can one of you pick this up?
BadSingleton commentedon Jan 29, 2021
Yup, I'll give it a go
BadSingleton commentedon Jan 29, 2021
The issue is actually that the
PythonExceptionclass is not explicitly marked as[Serializable](also needs the deserializaiton ctor)BadSingleton commentedon Feb 2, 2021
There is also something going on with the refcount. Not sure yet how, but the AggregateException (and InnerExceptions) lives for longer than it should.
filmor commentedon Feb 2, 2021
I ran into something like this on #1373, see 53e51a2.
_pyvaluedoesn't seem to be tracked properly.filmor commentedon Jun 14, 2022
The test is enabled nowadays, I guess this one is solved.