Repository navigation
[Performance] Make serialization support enabled optionally #1781
Description
Environment
- Pythonnet version: latest/current master
- Python version: *
- Operating System: *
- .NET Runtime: *
Details
With the objective of achieving the fastest pythonnet as possible, we've detected that there's a significant performance hit with the serialization feature. Specifically we saw the following pain points but there might be more:
- MaybeType<->Type conversions see https://github.com/pythonnet/pythonnet/blob/master/src/runtime/TypeManager.cs#L99
- Keeping track of objects in HashSet see for example https://github.com/pythonnet/pythonnet/blob/master/src/runtime/Types/ClrObject.cs#L15
It seems it could be enabled on demand based on a static configuration value maybe?
Activity
lostmsu commentedon May 2, 2022
I suppose the HashSet involvement can be put behind a boolean flag like
Runtime.Dangerous.AllowUndefinedShutdownBehavior. Without it the process may crash with segfault when Python or .NET runtime is unloaded when the process is stopping. Alternatively, you may try to re-engineer that bit to use a more performant collection, like a linked list. You would likely have to store some data on the Python side though.At the first glance the MaybeType <-> Type conversions could be restricted to
SaveRuntimeDataandRestoreRuntimeData, and the type ofcacheset toDictionary<Type, PyType>.PRs are welcome.