Skip to content

Update documentation to reflect API changes #2433

Open

Description

@TheJanzap

Similar to #2187, the Wiki also contains outdated code: The Threading page is still using PythonEngine.ImportModule().

There might be other pages that are outdated, like Loading Python file in .NET and Call function where Py.GIL() is not inside a using. I'm unsure if this is still correct.

I've also seen various code snippets where the new Runtime.DLL requirement is absent, most notably in the README and the documentation.

Activity

  1. filmor commented on Aug 8, 2024

    @filmor
    Member

    PRs are welcome. And the Wiki is open for changes anyway. If it is too wrong, we'll have to drop it.

  2. TheJanzap commented on Aug 22, 2024

    @TheJanzap
    Author

    Updated everything I've mentioned, except the use of Py.GIL() on the wiki page. I don't know enough about the Pythonnet code base to give a definitive answer wheter the code there could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions