This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Repository navigation
net_plugin fix for privacy groups corner case - #10390
Merged
Merged
Conversation
brianjohnson5972
suggested changes
May 22, 2021
brianjohnson5972
left a comment
Contributor
There was a problem hiding this comment.
I'd also like Kevin to look at this.
brianjohnson5972
self-requested a review
May 25, 2021 14:28
heifner
approved these changes
May 26, 2021
brianjohnson5972
approved these changes
May 26, 2021
praphael
pushed a commit
that referenced
this pull request
Jun 11, 2021
dimas1185
pushed a commit
that referenced
this pull request
Aug 14, 2021
This was referenced Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed test case that required node restart in
privacy_scenario_3_test.pyScenario:
after
node1launched it sends handshake tonode2node1is not in security group sonode2doesn't send back any notice (lib catchup notice was required in that case)node1was added to security group andnode2sends tonode1handshakein
sync 1scenario, whennet_pluginreceives non-first handshake with lib greater its own lib it do nothing.This fix adds sending handshake there also in case of non-first handshake generation
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions