Skip to content

Line-height property breaks text alignment (iOS) - #4909

Merged
hshristov merged 1 commit into
NativeScript:masterfrom
EddyVerbruggen:issue4906-lineheight-textalignment
Oct 20, 2017
Merged

Line-height property breaks text alignment (iOS)#4909
hshristov merged 1 commit into
NativeScript:masterfrom
EddyVerbruggen:issue4906-lineheight-textalignment

Conversation

@EddyVerbruggen

@EddyVerbruggen EddyVerbruggen commented Sep 30, 2017

Copy link
Copy Markdown
Contributor

Fixes #4906

@ghost ghost assigned EddyVerbruggen Sep 30, 2017
@ghost ghost added the in progress label Sep 30, 2017
@EddyVerbruggen EddyVerbruggen mentioned this pull request Sep 30, 2017
Closed
@EddyVerbruggen

EddyVerbruggen commented Oct 5, 2017

Copy link
Copy Markdown
Contributor Author

@vakrilov Any idea what's wrong with those unittests? (I can't access those servers)

@vakrilov

vakrilov commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

I think we had some connectivity issues on the CI server, so it might be something totally unrelated.. Will rerun them again.
run ci

@NativeScript NativeScript deleted a comment from vakrilov Oct 18, 2017
@NativeScript NativeScript deleted a comment from vakrilov Oct 18, 2017
@hshristov

hshristov commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

@EddyVerbruggen There are more values in the NSTextAlignment enum than our TextAlignment.

Wouldn't it be safer if we apply only matching values?

@EddyVerbruggen

EddyVerbruggen commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

@hshristov That makes sense, but I wonder if that hasn't already been checked at this point by this code?

@hshristov

hshristov commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

@EddyVerbruggen Lol the whole time I thought that you take the value from the JS object ...
Apparently I didn't paid enough attention. Nice shot 👍

@hshristov
hshristov merged commit d3a6a3f into NativeScript:master Oct 20, 2017
@ghost ghost removed the in progress label Oct 20, 2017
@EddyVerbruggen
EddyVerbruggen deleted the issue4906-lineheight-textalignment branch October 20, 2017 06:39
@ahmetceylan ahmetceylan mentioned this pull request Jun 19, 2019
Closed
@lock

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@hshristov hshristov hshristov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@EddyVerbruggen EddyVerbruggen

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Line-height property breaks text alignment (iOS)

4 participants

@EddyVerbruggen @vakrilov @hshristov @ns-bot