Repository navigation
Method overhaul with static PyMethodDef - #4873
Merged
Merged
Conversation
youknowone
marked this pull request as draft
April 12, 2023 18:10
youknowone
force-pushed
the
method
branch
9 times, most recently
from
April 19, 2023 10:23
b6605fe to
2fd0c36
Compare
Member
Author
|
This is rabbit hole. I touched builtin functions, method, module and every derived macros, and now reached bytecode |
Member
Author
Member
Author
|
@moreal This is not fully done, but could you give it a look? This is also related to |
youknowone
force-pushed
the
method
branch
5 times, most recently
from
April 29, 2023 13:57
ae46438 to
2d5364d
Compare
Member
Author
|
Finally all cpython test suite tests pass |
youknowone
marked this pull request as ready for review
April 30, 2023 03:27
Member
Author
|
@seungha-kim @moreal Could you review this PR? |
moreal
approved these changes
Apr 30, 2023
moreal
left a comment
Contributor
There was a problem hiding this comment.
I had tried to review it well but I'm not sure I've done a good job of reviewing long pieces of code. But I had read it once, and it builds and tests well, so I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found #4686 is related to multiple design caveats. I originally tried to edit small enough to support the original PR, but found this way will reduce total cost of effort about them.
closes #4686 by including all its changes.