Repository navigation
feat(user-agent): rename the client to socket-python-cli - #320
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
lelia
left a comment
There was a problem hiding this comment.
John-David Dalton (@jdalton) thanks for adding this, but I think we need to implement backend changes first before we rename on the client side.
I confirmed that backend attribution currently matches user-agents on exact, case sensitive prefixes, and currently only SocketPythonCLI/ is registered, meaning that this rename will cause us to silently lose Python CLI attribution as users upgrade.
By the way, the same class of change needs to take place on the SDK side, too - in fact, the SocketSDKPython/ user-agent appears to have never been registered on the backend. We may as well fix the gap everywhere in one go, if you're up for it.
d79c264 to
a4cc539
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c77895c to
a2e8bc6
Compare
Use one client name for CLI and SDK requests. Preserve the current release version and record the change under Unreleased.
a2e8bc6 to
ffcc07b
Compare
|
The backend now recognizes both CLI prefixes and |
Backend support for both CLI names and the SDK name has landed. The branch is refreshed and CI passes. Requesting a fresh review.
Use one lowercase
socket-python-cliUser-Agent name across direct and SDK requests, so API attribution stays consistent.Socket accepts both the old and new identifiers during rollout. Both code paths now use the same constant.
Both changed files parse, and no old identifier remains.