Repository navigation
Conversation
…th withArgs in refactor-jasmine-vitest Spy strategies configured for specific arguments, such as `spyOn(service, 'calc').withArgs(1).and.returnValue(2)`, were converted to `vi.spyOn(service, 'calc').mockReturnValue(undefined).withArgs(1).mockReturnValue(2)` without a TODO comment. Vitest mocks have no `withArgs` method, so the migrated test failed with a TypeError. Add a TODO comment for these strategies instead, since they need to be migrated manually, for example with `mockImplementation()`.
There was a problem hiding this comment.
Code Review
This pull request introduces support for handling Jasmine's .withArgs() spy strategy during the Jasmine-to-Vitest migration. Since Vitest does not have a direct equivalent, the transformer now identifies .withArgs() calls and inserts a TODO comment suggesting manual migration (e.g., using mockImplementation()). Corresponding unit tests and TODO note definitions have also been added. The feedback suggests using unwrapExpression(spyCall) to ensure that any transparent wrappers, such as parentheses or non-null assertions, are stripped before performing AST checks, preventing the withArgs check from being bypassed.
…ured with withArgs in refactor-jasmine-vitest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spy strategies configured for specific arguments, such as
spyOn(service, 'calc').withArgs(1).and.returnValue(2), were converted tovi.spyOn(service, 'calc').mockReturnValue(undefined).withArgs(1).mockReturnValue(2)without a TODO comment. Vitest mocks have nowithArgsmethod, so the migrated test failed with a TypeError.Add a TODO comment for these strategies instead, since they need to be migrated manually, for example with
mockImplementation().