Repository navigation
CAMEL-21873: camel-hibernate - options for both consumer and producer should be common options - #28530
Merged
davsclaus merged 1 commit intoOct 26, 2026
Conversation
… should be common options The selectionQuery, readOnly, filters and tenantIdentifier options were labelled producer,consumer which made the catalog group them as consumer options, causing the documentation examples to fail the catalog checks in CatalogDocExamplesTest. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
gnodet-bot
reviewed
Oct 26, 2026
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The fix is correct: removing label = "producer,consumer" from the four @UriParam annotations (selectionQuery, readOnly, filters, tenantIdentifier) makes them common options in Camel's framework, which is exactly the pattern camel-jpa uses for query/namedQuery. All generated artifacts (component JSON, catalog JSON, endpoint DSL) are consistent and correctly regenerated. The failing CatalogDocExamplesTest is a direct validation of this fix.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 8 of 708 tested, 25 compile-only — current: 8 all testedMaveniverse Scalpel detected 8 affected modules (current approach: 8). Skip-tests mode would test 8 modules (3 direct + 7 downstream), skip tests for 25 (generated code, meta-modules) Modules Scalpel would test (8)
Modules with tests skipped (25)
All tested modules (35 modules, 4m 49s total)Total reactor time: 4m 49s
Top 20 slowest modules:
|
This was referenced Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #27935 (CAMEL-21873, the new camel-hibernate component).
CatalogDocExamplesTest.everyYamlExampleOfTheDocumentationPassesTheCatalogChecks(camel-jbang-core) fails onmain, and on any PR whose CI runs it (see #28528):selectionQuery,readOnly,filtersandtenantIdentifierwere declared withlabel = "producer,consumer". The catalog therefore grouped them as consumer options, and the endpoint DSL generator left them out of the DSL builders entirely.Changes
HibernateEndpoint: removed theproducer,consumerlabel from these four options, so they become common options, ascamel-jpadoes forquery/namedQuery.HibernateEndpointBuilderFactorynow hasselectionQuery,readOnly,filtersandtenantIdentifieron the consumer, producer and common builders. The component is unreleased (4.24.0-SNAPSHOT), so nothing changes for released users.Testing
components/camel-hibernate:mvn install -DskipITspasses (52 tests).dsl/camel-jbang/camel-jbang-core:CatalogDocExamplesTestpasses.Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code