Repository navigation
Conversation
Add a separate workflow for the manual hooks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The manual workflow duplicates the Run pre-commit check name on pull requests, which can create ambiguous results and block merging if branch protection requires that check.
1 open issue
What changed in this PR
This PR advances the migration from pre-commit to prek described in #14093 and separates manual-stage hooks into their own CI workflow.
Changes:
- Replace explicit Python setup, installation, and caching with
j178/prek-action. - Run manual-stage hooks in a separate pull-request workflow.
- Update checkout and adjust cancellation behavior in both workflows.
| File | Description |
|---|---|
.github/workflows/pre-commit.yml |
Switch normal hooks to prek-action and remove manual-stage execution. |
.github/workflows/pre-commit-manual.yml |
Add a dedicated workflow for running manual-stage hooks with prek. |
Review effort: Balanced
jbampton
force-pushed
the
add-prek-action
branch
from
November 1, 2026 00:21
45a46f9 to
4ddc813
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14549 +/- ##
=========================================
Coverage 20.76% 20.76%
- Complexity 21905 21906 +1
=========================================
Files 6496 6496
Lines 591605 591605
Branches 72583 72583
=========================================
+ Hits 122854 122861 +7
+ Misses 455414 455407 -7
Partials 13337 13337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a separate workflow for the manual hooks
Description
This PR refs #14093
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?