Repository navigation
Fix reverse complement calculation in CDSSequence.getCodingSequence (#1016) - #1160
Open
nayanhasnolyf wants to merge 1 commit into
Open
nayanhasnolyf wants to merge 1 commit into
nayanhasnolyf wants to merge 1 commit into
Conversation
…iojava#1016) Signed-off-by: Nayan Pokhriyal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1016
CDSSequence.getCodingSequence()was callinggetSequenceAsString(getBioBegin(), getBioEnd(), getStrand()), which already returns the reverse complement forStrand.NEGATIVEviaAbstractLocation.reverseSequence(). After that,getCodingSequence()had a secondif (getStrand() == Strand.NEGATIVE)block that complemented the sequence again, cancelling out the complement and leaving the sequence only reversed.Removed the redundant second complement block in
CDSSequence.javaand enabled the existing@DisabledtestTranscriptSequenceTest.getCDNASeqNegativeStrand().