faulthandler stdlib module requires fileno on stdout #628

Activity

1. thomasballinger

   changed the title [-]AttributeError: 'FakeOutput' object has no attribute 'fileno'[/-] [+]faulthandler stdlib module requires fileno on stdout[/+] on Aug 5, 2016
2. thomasballinger commented on Aug 5, 2016

   

   thomasballinger

   on Aug 5, 2016

   Member

   More actions

   It looks like this is due to

   import faulthandler
   faulthandler.enable()

   Someone should look into what faulthandler and see what it wanted to do with fileno to see what we should do about it.

   • maybe we should give it the fileno of real stdout
   • maybe we should give it a new fileno it could write to that bpython could listen on
3. thomasballinger

   added

   bitesize

   help wanted

   on Aug 5, 2016
4. Kashyap12 commented on Nov 24, 2016

   

   Kashyap12

   on Nov 24, 2016

   More actions

   hi @thomasballinger , I am new to open source, would love to contribute
5. thomasballinger commented on Nov 24, 2016

   

   thomasballinger

   on Nov 24, 2016

   Member

   More actions

   @Kashyap12, great to hear, and welcome! Would you like to take a look at this issue? You can contact me at [email protected] or on freenode in #bpython if you want to talk in depth about how to get started or you have questions, or you're welcome to ask them here; @goetzc can mute this thread if it gets long ;)

   The first thing you'll want to do is to try out bpython; it'll be helpful context for this issue. You can either pip install it, which would work well enough to start working on this issue, or you can follow these instructions to get a version of the source code that's easy to change on your machine.

   There are a few tasks I can think of for this issue:

   • Reproducing the problem by installing pygtgraph and bpython and getting this error again
   • Looking at the source code for faulthandler to figure out why it needs with a fileno on stdout
   • Figuring out what behavior was expected here: what does running this code in the regular Python interpreter do?
   • Trying out adding in a fileno method to stdout that returns the real stdout fileno and seeing how that works

   Because faulthandler is part of the standard library, we should definitely try to find a solution that makes this work. I have some ideas (main one: making a new pipe that user Python code like this can write to that we'd combine with regular stdout.write output) but not enough information to know if that approach is necessary.
6. Kashyap12 commented on Nov 24, 2016

   

   Kashyap12

   on Nov 24, 2016

   More actions

   Hi @goetzc @thomasballinger , I tried to reproduce the same issue on my bpython set up, i.e.
   bpython version 0.16 on top of Python 2.7.6 /usr/bin/python , I pip installed pyqtgraph and then ran the below command on bpython :
   import pyqtgraph.examples

   I got no error :)
7. goetzc commented on Nov 24, 2016

   

   goetzc

   on Nov 24, 2016

   Author

   More actions

   FWIW, with bpython upgraded to 0.16 (and maintaining Python at 3.5.2) I don't get the error :)
8. Kashyap12 commented on Nov 25, 2016

   

   Kashyap12

   on Nov 25, 2016

   More actions

   @goetzc so is this issue closed?
9. thomasballinger commented on Nov 25, 2016

   

   thomasballinger

   on Nov 25, 2016

   Member

   More actions

   Oh great! It looks like this was fixed by #616.

   Thanks for digging into this more @Kashyap12, and thanks @goetzc for reporting and testing again!

   @Kashyap12, let me know if you're interested contributing more and would like suggestions for issues. bitesize would be a good place to start.
10. thomasballinger

    closed this as completedon Nov 25, 2016