Repository navigation
Support absolute paths in import completion skip list - #1060
Merged
sebastinas merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 76.51% 76.20% -0.32%
==========================================
Files 62 61 -1
Lines 8308 8295 -13
==========================================
- Hits 6357 6321 -36
- Misses 1951 1974 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968. Absolute entries in
import_completion_skiplistcurrently never match because the scanner compares only the last path component. Match absolute patterns against the resolved path and its parents, while retaining name-pattern matching for relative entries. This lets a user skip a directory even when one of its descendants appears directly in the module search path.The configuration documentation describes absolute paths and the existing limitation of colon-separated Windows drive-letter paths.
Validation:
pytest bpython/test/test_importcompletion.py -q(11 passed, 3 expected failures, 3 subtests passed)._staticand a duplicate label).