Repository navigation
Conversation
Interpolate on the source index axis and orient the fallback boundary using the minimum value-scale pixel. Co-authored-by: generaltony007 <[email protected]>
Assert the expected band is filled and outside remains unfilled for both index axes, independently reversed index/value scales, and hidden lower lines. Co-authored-by: generaltony007 <[email protected]>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A stacked line chart with
indexAxis: 'y'does not fill the band between datasets. Stack-target construction always interpolates usingx, even though the rest of the filler uses the source index axis. Its fallback boundary is also alwaysscale.bottom, so the fallback is wrong for horizontal value scales and for reversed value scales when no lower line is visible.Pass the source index axis to interpolation and orient the fallback boundary using the value scale's minimum pixel. This retains the existing minimum-value fallback for ordinary charts, without changing negative-stack semantics, stack membership, stepped lines, or handling of multi-segment interpolation arrays.
Tests
Sixteen pixel cases cover both index axes, independent index/value scale reversal, and visible/hidden lower datasets. Each asserts that the band is filled and the area outside it is not. Ten cases fail on unchanged master; all pass after the fix.
No Firefox test run is claimed.