Repository navigation
Add unit tests - #412
Add unit tests#412
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
============================================
+ Coverage 66.96% 69.79% +2.83%
- Complexity 3099 3256 +157
============================================
Files 198 198
Lines 13711 13718 +7
Branches 2142 2141 -1
============================================
+ Hits 9181 9574 +393
+ Misses 3949 3555 -394
- Partials 581 589 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@ibauersachs should I submit this PR to the dnsjava developers for evaluation? No rush just didn't want to miss something on my end. Thanks! |
|
Nothing missed on your end, I just haven't been working on dnsjava this summer and pursued outdoor activities. Come fall, I assume this will change again. Without having looked at the content yet, thanks a lot for your contribution! |
|
I really appreciate the detailed feedback, @ibauersachs ! I think I followed up and resolved all of the issues, but please let me know if I missed anything. Thank you! |
What: Add unit tests to cover some small gaps that existing in test coverage How: Making no changes to non-test code, this PR is strictly for adding unit tests.
281617e to
693b389
Compare
|
|
Sorry this took so long. |
What: Add unit tests to cover some small gaps that existing in test coverage
How: Making no changes to non-test code, this PR is strictly for adding unit tests.
Note: there is no associated issue.