Repository navigation
hosts: resolve PTR queries from the local hosts database - #413
Merged
Merged
Conversation
Reverse lookups now consult the hosts file the same way forward A/AAAA lookups already do, in both Lookup and LookupSession. Closes dnsjava#350
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #413 +/- ##
============================================
+ Coverage 66.69% 66.88% +0.18%
- Complexity 3074 3085 +11
============================================
Files 198 198
Lines 13645 13692 +47
Branches 2126 2140 +14
============================================
+ Hits 9101 9158 +57
+ Misses 3966 3953 -13
- Partials 578 581 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350. HostsFileParser can now resolve a reverse (PTR) lookup back to the first host name for an address, and both Lookup and LookupSession consult it for PTR queries the same way they already do for A and AAAA. Added unit tests for the parser and integration tests for both lookup paths.