Repository navigation
nd-widget UI controls - #1096
Draft
FlynnOConnell wants to merge 7 commits into
Draft
FlynnOConnell wants to merge 7 commits into
FlynnOConnell wants to merge 7 commits into
Conversation
FlynnOConnell
marked this pull request as draft
September 27, 2026 23:40
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/ui/ndw-controls |
Collaborator
Author
|
oops looks like we need account for toolbar space |
kushalkolar
reviewed
Oct 1, 2026
Comment on lines
+294
to
+304
| @property | ||
| def visible(self) -> bool: | ||
| """whether the window is drawn. A hidden edge window reserves no canvas space""" | ||
| return self._visible | ||
|
|
||
| @visible.setter | ||
| def visible(self, visible: bool): | ||
| self._visible = bool(visible) | ||
| # reserving windows change the layout when hidden or shown | ||
| if self._reserves and self._figure is not None: | ||
| self._figure._fpl_reset_layout() |
Member
There was a problem hiding this comment.
This is redundant since collapsed and size=0 exist?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Configurable
NDwidgetUI. See motivation here. Attempt 2, right panel is the desired look.I want the ability to hide the title/controls.
ui_kwargs=Noneui_kwargs={"playback": False}ui_kwargs={"title": None}ui_kwargs={"title": None, "playback": False}ui_kwargs={"visible": False}Should be easy enough to hook up to a right click menu for the bottom?