Repository navigation
Adding top gui to fpl - #999
Conversation
|
I'm brain fried I'll review tomorrow or this weekend, but if right and bottom imgui windows still work then it's probably fine, let's worry about left guis when there's a compelling use case? |
|
Okay, the reason that it is not shifting down is because updates to the layout use the fractional layout to resize, and the rect manager does not take into account x or y offset when doing this |
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/top-gui |
|
@kushalkolar gtg if you can give a review! |
|
Tested that the window layouts subplots move and resize properly with these changes? We can make automated tests for that later. |
I tested locally that the window layout examples are still working (resizing and moving subplots around) |
|
The example png file got committed directly to git instead of git lfs, no idea why 🤦♂️ . I wonder if there's CI action we can use to catch this in the future. Since this was a recent commit to main I think we can undo it without too much trouble. |
|
🤦 Wow that is totally my fault I can open a PR to fix today. I need to go in and fix the contrib docs so that they are a little clearer on the screenshot uploads. |
|
It shouldn't be possible, seems git just ignored the .gitattributes for some reason |


I thought this would follow the patterns of the other guis (just change the y pos of where pygfx renders to), but the render space does not actually move down unless I manually set the rect
Maybe that is not something that needs to be done for bottom and right but does for a left or top gui
Have enough for the thing I need to do for clepio and can circle back to this
@kushalkolar thoughts welcome since you did the frame/rect manager stuff