Repository navigation
feat: Add zoom, scroll and hover values to the monitoring charts - #7090
Open
patelchaitany wants to merge 1 commit into
Open
patelchaitany wants to merge 1 commit into
patelchaitany wants to merge 1 commit into
Conversation
The DQM time series and distribution charts were static SVG with no way to read exact values, and the time series joined every window length into one line. - Time series: plot one window length at a time (the one picked in View, or daily when View is the baseline) and keep the baseline row off the line. - Time series and distribution: hover shows exact values, drag to zoom, zoom in/out/reset buttons, and sideways scrolling through all the data while zoomed in. - Distribution: leave room above the plot so the top axis label is not cut off. Signed-off-by: Chaitany Patel <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7090 +/- ##
==========================================
+ Coverage 50.97% 50.99% +0.01%
==========================================
Files 455 455
Lines 56994 56994
Branches 8321 8321
==========================================
+ Hits 29055 29063 +8
+ Misses 25954 25946 -8
Partials 1985 1985
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The data quality monitoring charts on the feature detail page are hand-drawn SVG with no interaction. You cannot read exact values, zoom into a crowded range, or look at small bars. The time series also draws every row the API returns as one line, so different window lengths (daily, weekly, monthly, quarterly) and the baseline are joined together. That creates spikes and drops that are not in the data.
This PR is UI only. The API and the stored metrics are unchanged.
Time series
Distribution (numeric histogram)
The zoom, scroll, hover and tooltip code is shared in
ui/src/pages/monitoring/components/chartZoom.tsx.Screenshots
Demo data: one feature view, hourly data for 20 drivers from 2026-07-01 to 2026-10-29, with daily, weekly and monthly metrics plus the baseline.
conv_ratedrifts upward and has a null spike on Oct 4–9.Time series, All time
Time series, Last 30 days
Time series: zoom, hover and scroll
Distribution
Which issue(s) this PR fixes:
Part of #7054: fixes case 3 (the time series mixes window lengths) and keeps the baseline off the time-series line. Cases 1, 2 and 4 are not changed here. #7056 and #7057 also edit
FeatureMetricsDetail.tsx, so whichever merges second will need a small rebase.Checks
git commit -s)Testing Strategy
Unit test:
ui/src/pages/monitoring/FeatureMetricsDetail.test.tsxchecks that only the selected window length is plotted, drag-to-zoom, sideways scrolling, double-click reset, and the hover values on the time series and the distribution. All 21 UI tests,tsc, ESLint and Prettier pass.Manual: built the UI and ran
feast uion the demo repo above; checked every time range, the View dropdown, numeric and categorical features, the expanded histogram, and the feature Monitoring tab.Misc