Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #191348
Related to #193557
Related to #193205
Related to #195708
What changed
I fixed a log-level filtering bug in
FlutterActivityTest.kt'sgetGraphicsPipelineErrorsand extracted explicit fatal graphics error matching intoGraphicsErrorLogFilter.ktinsidedev/integration_tests/android_hardware_smoke_test.Previously,
templateTestlogged its attempt boundary marker viaLog.i(TAG, marker)(INFOpriority), whereasgetGraphicsPipelineErrorsqueriedlogcat -d --pid=$pid *:W(WARNand above). Because*:Wstripped allINFOlines from the dump,seenMarkernever flipped totrueand process-level EGL or Vulkan errors went undetected during instrumented runs. At the same time, matching any post-marker line containing"HWUI"or"EGL_"matched benign warnings emitted unconditionally by Android'sHWUIRenderThreadon emulators (Failed to choose config with EGL_SWAP_BEHAVIOR_PRESERVED,101010-2 ... error = EGL_SUCCESS,Unknown dataspace 0, and slow-frameHWUI: Davey!logs), which would immediately preemptBlankScreenshotExceptionretries once marker detection armed.getGraphicsPipelineErrorsnow passeslogcat -d --pid=$pid $TAG:I *:Wso theLog.iboundary marker remains visible in the dump, andGraphicsErrorLogFiltermatches explicit unrecoverable EGL, Vulkan, and emulator host-pipe errors while excluding'EGL_SWAP_BEHAVIOR_PRESERVED'and'error = EGL_SUCCESS'specifically (preserving reallibEGLeglInitialize(...) failed (EGL_SUCCESS)disconnect detection).Pre-launch Checklist
///).