Repository navigation
Fix uncaught json::out_of_range in parseJson/parseYaml causing abort() - #1341
Open
0xOverlordX wants to merge 1 commit into
Open
0xOverlordX wants to merge 1 commit into
0xOverlordX wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the exception handling in core/vm.cpp by catching the broader json::exception instead of json::parse_error, and adds a catch block for json::exception during YAML-to-JSON parsing. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Impact
std.parseJson("1e400") crashes the process with abort() via SIGABRT. This is a denial-of-service vulnerability , any application embedding libjsonnet that evaluates untrusted Jsonnet input can be killed instantly with a single line of Jsonnet.
The abort() is not catchable by the embedding application. There is no way to recover.
This affects any tool built on libjsonnet that processes user-supplied Jsonnet, including CI/CD pipelines, Kubernetes config generators (Tanka, Kubecfg), and multi-tenant services.
Root Cause
builtinParseJson() in core/vm.cpp catches json::parse_error but not json::out_of_range. When nlohmann throws out_of_range for unrepresentable numbers like 1e400, the exception escapes to the TRY/CATCH macro which calls abort().
Same issue in builtinParseYaml().
Fix
Catch json::exception (the common base class) instead of just json::parse_error. This turns the crash into a normal Jsonnet RUNTIME ERROR that callers can handle gracefully.
Before
jsonnet -e 'std.parseJson("1e400")'
After
jsonnet -e 'std.parseJson("1e400")'