Repository navigation
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (7 classes)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone carriage returns did not advance the lexer's line counter, so AST nodes and errors after a CR were reported on the previous line. For example, parsing
{ f(arg: "😀")\r ) }reported line 1, column 16; it now reports line 2, column 2.This change applies the GraphQL Line Terminators rules throughout parsing:
Added 32 Spock regression cases covering AST and error locations, code-point columns after emoji, comments, EOF, validation errors, multiple sources, mixed line endings, reader-buffer boundaries, block-string values, and captured whitespace. Thirteen cases failed before the fix. Updated the existing ignored-character test to expect the corrected positions after CR, and restored the JVM-wide parser options after the existing options test to prevent it from affecting later tests.
Added explicit ignored-character capture tests for 43 AST node types, checking exact surrounding spaces, tabs, commas, CR, LF, and CRLF when capture is enabled and empty captures when disabled. These tests use per-parse options. This preserves coverage after fixing the global-options leak: the master baseline had exercised 33 builders only because an earlier test left capture enabled for later tests. The coverage baseline is unchanged.
Validation:
./gradlew test testng jacocoTestReport(excluding two uncommitted local Unicode investigation tests).git diff --checkand the repository's pre-commit file checks pass.