Repository navigation
fix: normalize nested arrays after filtering null values - #496
Draft
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
Draft
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
Conversation
|
JOJO (@moneymaker26754-crypto) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With stripNulls enabled, a reply such as {"groups":[null,[null,1]]} fails validation against groups:number[][] instead of producing [[1]]. Filtering the outer array assigns a new array to obj[k], but recursion still visits the old array held in value. Nested replacements are therefore disconnected from the returned structure.
Keep value synchronized with the assigned filtered array before recursing. Add two offline translator regressions using the real TypeScript validator, with repair disabled so a second response cannot hide the failure. The default stripNulls behavior and existing deletion policy are unchanged.
Validation (Node 24.22.1, Windows):
New locally reproduced problem; no separate issue has been filed. Prepared with AI assistance; proposed as a draft pending human review.