Repository navigation
fix(program): preserve literal __proto__ fields in generated modules - #497
Draft
JOJO (moneymaker26754-crypto) wants to merge 1 commit into
Conversation
|
JOJO (@moneymaker26754-crypto) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JSON object with an own proto field is not preserved by createModuleTextFromProgram. The generated object literal uses "proto": value, which JavaScript interprets specially instead of defining the original data field. The interpreter already preserves the field via Object.fromEntries.
Emit a computed property name for this one key, retaining the existing output form for ordinary keys. Add three cases (string, object and null values) that execute the generated module after removing its type-only scaffolding, assert the own property and serialized data, and compare with interpreter output. Execution is confined to controlled test fixtures; production code only generates text as before.
Validation (Node 24.22.1, Windows):
Related PR #448 addresses instance-method shadowing in the same files and is a separate fix. New locally reproduced problem; no separate issue has been filed.
Prepared with AI assistance; proposed as a draft pending human review.