Repository navigation
fix(ts): handle shadowed hasOwnProperty in programs - #500
Open
berce (bercedev) wants to merge 1 commit into
Open
berce (bercedev) wants to merge 1 commit into
berce (bercedev) wants to merge 1 commit into
Conversation
Check own properties without invoking methods on parsed program values. Cover malformed steps and valid object arguments.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the change to make property checks safe against hasOwnProperty shadowing.
No open issues 🎉
What changed in this PR
Fixes #488 by making TypeScript program property checks safe when parsed JSON defines its own hasOwnProperty value, preserving error-result handling for malformed steps.
Changes:
- Uses
Object.prototype.hasOwnProperty.callthroughout code generation and evaluation. - Adds regression tests for malformed steps and valid object arguments containing
hasOwnProperty.
| File | Description |
|---|---|
typescript/test/program.test.ts |
Adds three regression tests covering validation, code generation, and evaluation. |
typescript/src/ts/program.ts |
Replaces direct property-check calls with shadowing-safe checks. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #488.
Parsed JSON can define its own
hasOwnPropertyvalue. The program validator then throws instead of returning an error result. Check properties throughObject.prototypein code generation and evaluation, and cover malformed steps and valid object arguments with regression tests.Focused program tests: 24/24 passed in an offline Podman container (unrelated compiler imports were stubbed). Full
npm testcould not run because the locked dependencies were not cached and package downloads were blocked.